Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webhook): refactor sidecar injection #234

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

mlycore
Copy link
Member

@mlycore mlycore commented Aug 5, 2022

What is changed and how it works?

  • refactor sidecar injection

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #234 (08ce0f3) into master (ac4ece7) will increase coverage by 30.91%.
The diff coverage is 42.10%.

@@             Coverage Diff             @@
##           master     #234       +/-   ##
===========================================
+ Coverage   30.68%   61.59%   +30.91%     
===========================================
  Files           3        7        +4     
  Lines         264      427      +163     
===========================================
+ Hits           81      263      +182     
+ Misses        177      158       -19     
  Partials        6        6               
Flag Coverage Δ
unittests 61.59% <42.10%> (+30.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/webhook/injection.go 18.58% <22.89%> (ø)
pisa-controller/pkg/proxy/http.go 57.89% <40.00%> (+57.89%) ⬆️
pisa-controller/pkg/webhook/types.go 64.00% <64.00%> (ø)
pisa-controller/pkg/proxy/builder.go 91.21% <100.00%> (+51.11%) ⬆️
pisa-controller/pkg/webhook/api_check.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mlycore mlycore requested a review from windghoul August 5, 2022 10:30
@mlycore mlycore added this to the v0.3.0 milestone Aug 5, 2022
@mlycore mlycore changed the title WIP: refactor(webhook): refactor sidecar injection refactor(webhook): refactor sidecar injection Aug 5, 2022
@windghoul windghoul merged commit 0072ec8 into database-mesh:master Aug 5, 2022
@mlycore mlycore deleted the ut-controller branch September 7, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants