Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pisa-proxy, protocol): add packet codec #263

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

xuanyuan300
Copy link
Contributor

Signed-off-by: xuanyuan300 [email protected]

What is changed and how it works?

What's Changed:

  1. Add packet codec.
    Used to reading packet from client side.

Used to reading packet from client side.

Signed-off-by: xuanyuan300 <[email protected]>
@xuanyuan300 xuanyuan300 requested a review from wbtlb August 16, 2022 07:09
@xuanyuan300 xuanyuan300 added app:pisa-proxy Pisa-Proxy related changes in:protocol Protocol related changes labels Aug 16, 2022
@xuanyuan300 xuanyuan300 added this to the v0.3.0 milestone Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #263 (7bba61d) into master (df61eb4) will increase coverage by 3.32%.
The diff coverage is 79.68%.

❗ Current head 7bba61d differs from pull request most recent head 07db0cd. Consider uploading reports for the commit 07db0cd to get more accurate results

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   66.97%   70.30%   +3.32%     
==========================================
  Files           7        6       -1     
  Lines         427      495      +68     
==========================================
+ Hits          286      348      +62     
- Misses        133      137       +4     
- Partials        8       10       +2     
Flag Coverage Δ
unittests 70.30% <79.68%> (+3.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 58.62% <53.84%> (+0.72%) ⬆️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 91.21% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Also, optimze encode, add encode_packet

Signed-off-by: xuanyuan300 <[email protected]>
1. remove unwrap for make_tls for LocalStream of server
2. add server handshake codec

Signed-off-by: xuanyuan300 <[email protected]>
@wbtlb wbtlb merged commit da78ddb into database-mesh:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-proxy Pisa-Proxy related changes in:protocol Protocol related changes size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants