Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add nodegroup builder and shard controller #326

Merged
merged 6 commits into from
Sep 24, 2022

Conversation

mlycore
Copy link
Member

@mlycore mlycore commented Sep 24, 2022

What is changed and how it works?

What's Changed:

  • Add NodeGroupBuilder to ProxyBuilder for generating NodeGroup of ProxyConfig
  • Add DataShard to ProxyConfig and build from DataShard CRD.
  • Add unit test for ProxyBuilder

@mlycore mlycore requested a review from xuanyuan300 September 24, 2022 09:27
@mlycore mlycore added app:pisa-controller Pisa-Controller related changes in:config Configuration related changes in:test Test related changes labels Sep 24, 2022
@mlycore mlycore added this to the v0.3.0 milestone Sep 24, 2022
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Merging #326 (4d7a095) into master (df61eb4) will increase coverage by 5.14%.
The diff coverage is 85.92%.

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   66.97%   72.12%   +5.14%     
==========================================
  Files           7        6       -1     
  Lines         427      574     +147     
==========================================
+ Hits          286      414     +128     
- Misses        133      147      +14     
- Partials        8       13       +5     
Flag Coverage Δ
unittests 72.12% <85.92%> (+5.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 58.62% <53.84%> (+0.72%) ⬆️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 89.08% <91.83%> (-2.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuanyuan300 xuanyuan300 merged commit 5ad74ab into database-mesh:master Sep 24, 2022
@mlycore mlycore deleted the shard-config branch September 26, 2022 07:30
xuanyuan300 pushed a commit to xuanyuan300/pisanix that referenced this pull request Oct 10, 2022
…e-mesh#326)

* feat(controller): add NodeGroupConfigBuilder

Signed-off-by: mlycore <[email protected]>

* chore: update go mod with updated golang-sdk

Signed-off-by: mlycore <[email protected]>

* feat(controller): add DataShard for ProxyConfig builder

Signed-off-by: mlycore <[email protected]>

* feat(controller): add shard builder

Signed-off-by: mlycore <[email protected]>

* feat(controller): add unit test for shard builder

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix unit test

Signed-off-by: mlycore <[email protected]>

Signed-off-by: mlycore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-controller Pisa-Controller related changes in:config Configuration related changes in:test Test related changes size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants