-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): add nodegroup builder and shard controller #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mlycore <[email protected]>
Signed-off-by: mlycore <[email protected]>
Signed-off-by: mlycore <[email protected]>
Signed-off-by: mlycore <[email protected]>
Signed-off-by: mlycore <[email protected]>
mlycore
added
app:pisa-controller
Pisa-Controller related changes
in:config
Configuration related changes
in:test
Test related changes
labels
Sep 24, 2022
Signed-off-by: mlycore <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 66.97% 72.12% +5.14%
==========================================
Files 7 6 -1
Lines 427 574 +147
==========================================
+ Hits 286 414 +128
- Misses 133 147 +14
- Partials 8 13 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xuanyuan300
approved these changes
Sep 24, 2022
xuanyuan300
pushed a commit
to xuanyuan300/pisanix
that referenced
this pull request
Oct 10, 2022
…e-mesh#326) * feat(controller): add NodeGroupConfigBuilder Signed-off-by: mlycore <[email protected]> * chore: update go mod with updated golang-sdk Signed-off-by: mlycore <[email protected]> * feat(controller): add DataShard for ProxyConfig builder Signed-off-by: mlycore <[email protected]> * feat(controller): add shard builder Signed-off-by: mlycore <[email protected]> * feat(controller): add unit test for shard builder Signed-off-by: mlycore <[email protected]> * fix(controller): fix unit test Signed-off-by: mlycore <[email protected]> Signed-off-by: mlycore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app:pisa-controller
Pisa-Controller related changes
in:config
Configuration related changes
in:test
Test related changes
size/XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
What's Changed: