Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pisa-daemon, config): add Endpoint field to Service #351

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

xuanyuan300
Copy link
Contributor

@xuanyuan300 xuanyuan300 commented Oct 8, 2022

Signed-off-by: xuanyuan300 [email protected]

What is changed and how it works?

What's Changed:

  1. Add Endpoint field to Service.
  2. Changed qos_group type from Vec to Option.
  3. Fix some unit test error.

@xuanyuan300 xuanyuan300 requested a review from mlycore October 8, 2022 03:16
@xuanyuan300 xuanyuan300 added in:config Configuration related changes app:pisa-daemon Pisa-Daemon related changes labels Oct 8, 2022
@xuanyuan300 xuanyuan300 added this to the v0.3.1 milestone Oct 8, 2022
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #351 (a8ee8c5) into master (df61eb4) will increase coverage by 5.71%.
The diff coverage is 84.84%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   66.97%   72.69%   +5.71%     
==========================================
  Files           7        6       -1     
  Lines         427      597     +170     
==========================================
+ Hits          286      434     +148     
- Misses        133      152      +19     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 72.69% <84.84%> (+5.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) ⬇️
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 53.75% <43.24%> (-4.15%) ⬇️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 92.95% <98.64%> (+1.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mlycore mlycore merged commit 696d55a into database-mesh:master Oct 8, 2022
xuanyuan300 added a commit to xuanyuan300/pisanix that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-daemon Pisa-Daemon related changes in:config Configuration related changes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants