Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add PisaDaemonConfig handler and builders #354

Merged
merged 7 commits into from
Oct 9, 2022

Conversation

mlycore
Copy link
Member

@mlycore mlycore commented Oct 9, 2022

What is changed and how it works?

What's Changed:

  • Add handler for Pisa-Daemon config
  • Add Pisa-Daemon config definition
  • Add unit test for PisaDaemonConfigBuilder

@mlycore mlycore requested a review from xuanyuan300 October 9, 2022 09:44
@mlycore mlycore added type:enhancement New feature or request app:pisa-controller Pisa-Controller related changes in:http Http module related changes in:config Configuration related changes in:test Test related changes in:api API related changes in:crd CRD related changes labels Oct 9, 2022
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #354 (f10b982) into master (df61eb4) will increase coverage by 5.71%.
The diff coverage is 84.84%.

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   66.97%   72.69%   +5.71%     
==========================================
  Files           7        6       -1     
  Lines         427      597     +170     
==========================================
+ Hits          286      434     +148     
- Misses        133      152      +19     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 72.69% <84.84%> (+5.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) ⬇️
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 53.75% <43.24%> (-4.15%) ⬇️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 92.95% <98.64%> (+1.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuanyuan300 xuanyuan300 merged commit 9aa194c into database-mesh:master Oct 9, 2022
@mlycore mlycore deleted the daemon-config branch October 9, 2022 09:48
@mlycore mlycore added this to the v0.3.1 milestone Oct 9, 2022
xuanyuan300 pushed a commit to xuanyuan300/pisanix that referenced this pull request Oct 10, 2022
…-mesh#354)

* feat(controller): add daemon config type definition

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix daemon config

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix unit test

Signed-off-by: mlycore <[email protected]>

* chore(mod): update crd type definition

Signed-off-by: mlycore <[email protected]>

* feat(kubernetes): add helper function for VirtualDatabaseList and TrafficQoS

Signed-off-by: mlycore <[email protected]>

* feat(trafficqos): add PodContainerBinding for DaemonConfig

Signed-off-by: mlycore <[email protected]>

* feat(controller): using non namespaced url for DaemonConfig

Signed-off-by: mlycore <[email protected]>

Signed-off-by: mlycore <[email protected]>
xuanyuan300 pushed a commit to xuanyuan300/pisanix that referenced this pull request Oct 10, 2022
…-mesh#354)

* feat(controller): add daemon config type definition

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix daemon config

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix unit test

Signed-off-by: mlycore <[email protected]>

* chore(mod): update crd type definition

Signed-off-by: mlycore <[email protected]>

* feat(kubernetes): add helper function for VirtualDatabaseList and TrafficQoS

Signed-off-by: mlycore <[email protected]>

* feat(trafficqos): add PodContainerBinding for DaemonConfig

Signed-off-by: mlycore <[email protected]>

* feat(controller): using non namespaced url for DaemonConfig

Signed-off-by: mlycore <[email protected]>

Signed-off-by: mlycore <[email protected]>
xuanyuan300 pushed a commit to xuanyuan300/pisanix that referenced this pull request Oct 10, 2022
…-mesh#354)

* feat(controller): add daemon config type definition

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix daemon config

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix unit test

Signed-off-by: mlycore <[email protected]>

* chore(mod): update crd type definition

Signed-off-by: mlycore <[email protected]>

* feat(kubernetes): add helper function for VirtualDatabaseList and TrafficQoS

Signed-off-by: mlycore <[email protected]>

* feat(trafficqos): add PodContainerBinding for DaemonConfig

Signed-off-by: mlycore <[email protected]>

* feat(controller): using non namespaced url for DaemonConfig

Signed-off-by: mlycore <[email protected]>

Signed-off-by: mlycore <[email protected]>
Signed-off-by: xuanyuan300 <[email protected]>
wbtlb pushed a commit that referenced this pull request Oct 10, 2022
)

* feat(docs): add version v0.2.0 docs
Signed-off-by: xuanyuan300 <[email protected]>

Signed-off-by: xuanyuan300 <[email protected]>

* Update build.yml

Signed-off-by: xuanyuan300 <[email protected]>

* Create release.yml

Signed-off-by: xuanyuan300 <[email protected]>

* Update release.yml

Signed-off-by: xuanyuan300 <[email protected]>

* Update release.yml

Signed-off-by: xuanyuan300 <[email protected]>

* feat(controller): add PisaDaemonConfig handler and builders (#354)

* feat(controller): add daemon config type definition

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix daemon config

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix unit test

Signed-off-by: mlycore <[email protected]>

* chore(mod): update crd type definition

Signed-off-by: mlycore <[email protected]>

* feat(kubernetes): add helper function for VirtualDatabaseList and TrafficQoS

Signed-off-by: mlycore <[email protected]>

* feat(trafficqos): add PodContainerBinding for DaemonConfig

Signed-off-by: mlycore <[email protected]>

* feat(controller): using non namespaced url for DaemonConfig

Signed-off-by: mlycore <[email protected]>

Signed-off-by: mlycore <[email protected]>
Signed-off-by: xuanyuan300 <[email protected]>

* feat(pisa-proxy, sharding): support min, max agg function for merge
stream

Signed-off-by: xuanyuan300 <[email protected]>

* fix(ci): fix conflicts
Signed-off-by: xuanyuan300 <[email protected]>

Signed-off-by: xuanyuan300 <[email protected]>

* fix(docs): fix conflicts
Signed-off-by: xuanyuan300 <[email protected]>

Signed-off-by: xuanyuan300 <[email protected]>

* fix(docs): fix conflicts
Signed-off-by: xuanyuan300 <[email protected]>

Signed-off-by: xuanyuan300 <[email protected]>

* feat(pisa-proxy, sharding): add avg for merge stream
Signed-off-by: xuanyuan300 <[email protected]>

Signed-off-by: xuanyuan300 <[email protected]>

* chore(pisa-proxy, sharding): remove comments
Signed-off-by: xuanyuan300 <[email protected]>

Signed-off-by: xuanyuan300 <[email protected]>

Signed-off-by: xuanyuan300 <[email protected]>
Signed-off-by: mlycore <[email protected]>
Co-authored-by: liyao <[email protected]>
xuanyuan300 pushed a commit to xuanyuan300/pisanix that referenced this pull request Oct 15, 2022
…-mesh#354)

* feat(controller): add daemon config type definition

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix daemon config

Signed-off-by: mlycore <[email protected]>

* fix(controller): fix unit test

Signed-off-by: mlycore <[email protected]>

* chore(mod): update crd type definition

Signed-off-by: mlycore <[email protected]>

* feat(kubernetes): add helper function for VirtualDatabaseList and TrafficQoS

Signed-off-by: mlycore <[email protected]>

* feat(trafficqos): add PodContainerBinding for DaemonConfig

Signed-off-by: mlycore <[email protected]>

* feat(controller): using non namespaced url for DaemonConfig

Signed-off-by: mlycore <[email protected]>

Signed-off-by: mlycore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-controller Pisa-Controller related changes in:api API related changes in:config Configuration related changes in:crd CRD related changes in:http Http module related changes in:test Test related changes size/L type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants