Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pisa-daemon): add PisaDaemonConfigBuilder #360

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

mlycore
Copy link
Member

@mlycore mlycore commented Oct 10, 2022

What is changed and how it works?

What's Changed:

  • Add PisaDaemonConfigBuilder as retrieve config from PisaController
  • Introduce clap and reqwest to cargo

Verified

This commit was signed with the committer’s verified signature.
bkueng Beat Küng
Signed-off-by: mlycore <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
bkueng Beat Küng
Signed-off-by: mlycore <[email protected]>
@mlycore mlycore added type:enhancement New feature or request in:http Http module related changes in:config Configuration related changes app:pisa-daemon Pisa-Daemon related changes labels Oct 10, 2022
@mlycore mlycore added this to the v0.3.1 milestone Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #360 (2502fbd) into master (df61eb4) will increase coverage by 7.88%.
The diff coverage is 85.09%.

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
+ Coverage   66.97%   74.86%   +7.88%     
==========================================
  Files           7        6       -1     
  Lines         427      716     +289     
==========================================
+ Hits          286      536     +250     
- Misses        133      169      +36     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 74.86% <85.09%> (+7.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) ⬇️
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 51.35% <44.11%> (-6.55%) ⬇️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 94.62% <99.15%> (+3.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuanyuan300 xuanyuan300 merged commit 6124756 into database-mesh:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-daemon Pisa-Daemon related changes in:config Configuration related changes in:http Http module related changes size/L type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants