Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(parser): add create role sql parser. #373

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

dongzl
Copy link
Contributor

@dongzl dongzl commented Oct 21, 2022

Signed-off-by: Zonglei Dong [email protected]

What is changed and how it works?

ref #61

What's Changed:

Related changes

  • add create role sql parser.
  • add create role sql parser test case.

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #373 (f8ca63b) into master (df61eb4) will increase coverage by 7.88%.
The diff coverage is 85.09%.

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
+ Coverage   66.97%   74.86%   +7.88%     
==========================================
  Files           7        6       -1     
  Lines         427      716     +289     
==========================================
+ Hits          286      536     +250     
- Misses        133      169      +36     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 74.86% <85.09%> (+7.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pisa-controller/pkg/proxy/server.go 20.00% <0.00%> (-2.23%) ⬇️
pisa-controller/pkg/webhook/server.go 26.66% <0.00%> (ø)
pisa-controller/pkg/proxy/http.go 51.35% <44.11%> (-6.55%) ⬇️
pisa-controller/pkg/webhook/injection.go 59.02% <82.56%> (+20.08%) ⬆️
pisa-controller/pkg/proxy/builder.go 94.62% <99.15%> (+3.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mlycore mlycore self-assigned this Oct 27, 2022
@mlycore mlycore added type:enhancement New feature or request app:pisa-proxy Pisa-Proxy related changes in:parser Parser related changes labels Oct 27, 2022
@mlycore mlycore merged commit 0c52afd into database-mesh:master Oct 27, 2022
@dongzl dongzl deleted the create_role_stmt branch October 27, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-proxy Pisa-Proxy related changes in:parser Parser related changes size/S type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants