Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix parsing prepare packet error #73

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

xuanyuan300
Copy link
Contributor

@xuanyuan300 xuanyuan300 commented Jun 7, 2022

What is changed and how it works?

What's Changed:

  1. Fix parsing prepare return packet error
    Pisa hangs when executing a long prepare statement, such as INSERT INTO my_table (id, name) values ​​(?, ?), (?, ?), (?, ?),...

@xuanyuan300 xuanyuan300 added the in:protocol Protocol related changes label Jun 7, 2022
@xuanyuan300 xuanyuan300 added this to the v0.1.1 milestone Jun 7, 2022
@xuanyuan300 xuanyuan300 requested a review from wbtlb June 7, 2022 12:54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: xuanyuan300 <[email protected]>
@wbtlb wbtlb merged commit be55f59 into database-mesh:master Jun 7, 2022
@xuanyuan300 xuanyuan300 added the type:bug Misbehavior label Jun 7, 2022
@mlycore
Copy link
Member

mlycore commented Jun 7, 2022

Please add more description about this bug. @xuanyuan300

@xuanyuan300 xuanyuan300 added the app:pisa-proxy Pisa-Proxy related changes label Jun 26, 2022
mlycore pushed a commit to mlycore/pisanix that referenced this pull request Jul 1, 2022
* fix(protocol): fix parsing prepare packet error

* chore(protocol): remove unused comments

Signed-off-by: xuanyuan300 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:pisa-proxy Pisa-Proxy related changes in:protocol Protocol related changes size/L type:bug Misbehavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants