-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accumulation issues during counting #56
Labels
Comments
donaldcampbelljr
added a commit
that referenced
this issue
Dec 12, 2024
2 tasks
The latest updates from
|
Indeed, there are multiples:
|
Did you clear the output directory before re-running? It will not overwrite but rather append files that are already present. |
Closing with 0.2.0 Release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently seeing accumulations during some counting functions while using gtars uniwig within the PEPATAC pipeline. Seems to be caused by a couple of issues.
Example of what this looks like in IGV when comparing
bw
files:This issue appears to be rooted in the
variable_shifted_bam_to_bw
function and can be caused by two different events.For the 2nd issue, because
variable_shifted_bam_to_bw
takes either the start or the end and uses it as the adjusted_start_site (or cut_size), occaisionally there is a situation where the newest coordinate and its corresponding endsite is less than the current coordinate position and current endsite. This can cause a count to accumulate which is never decremented. You can attempt to add this new, lower endsite to the endsite queue but the coordinate position is already accounted for. Since we push to these count vectors instead of accessing by index, this causes problems if we try to count previously passed coordinates. A simple solution is to just skip these counts. Another method would be to refactor and use an approach where we access elements in the count array via index.Example of what this looks like as an output.
The text was updated successfully, but these errors were encountered: