-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ga4gh refget digest functionality #58
Conversation
Do you know why I can't do this?
When I can do this?
|
Two things:
from .gtars.digests import * You can place a The reason this |
yeah I had figured that out, but even after adding that I still get the same issue... |
But now the error is different:
|
I think we are missing // set names of submodules
sys_modules.set_item("gtars.tokenizers", m.getattr("tokenizers")?)?;
sys_modules.set_item("gtars.ailist", m.getattr("ailist")?)?;
sys_modules.set_item("gtars.utils", m.getattr("utils")?)?;
sys_modules.set_item("gtars.models", m.getattr("models")?)?;
// <-------- add your module here? |
Yep that was what I was missing. it works now! thanks. |
Do we want to merge this soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks for adding tests and docs, too.
Adds a new
digests
module that provides md5 and ga4gh digest computation for strings and fasta files.I did not implement a CLI for it, just rust library functions and python bindings.
I confirmed the python bindings work for me locally.