Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #64 and #65 #66

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Fixes for #64 and #65 #66

merged 6 commits into from
Jan 10, 2025

Conversation

donaldcampbelljr
Copy link
Member

Fixes #64
Adds enhancement #65

For #64, note that the start and core wiggles will be shifted by 1 since we are converting from bed files(0 based) to wiggles (1 based). The npy files are not shifted so the start and core positions will be 1 less than the wiggle counter parts.

However, because a bed file's end positions are 1 based, no shifting is done for the ends. Therefore, the npy and wig start positions for the end files should be the same.

@donaldcampbelljr donaldcampbelljr changed the base branch from master to dev January 9, 2025 22:50
@donaldcampbelljr
Copy link
Member Author

@ClaudeHu please test this and confirm it meets your needs. See above for differences between wig and npy start positions.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 92.20779% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.22%. Comparing base (47b6316) to head (8ae3d41).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
gtars/src/uniwig/mod.rs 91.54% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #66      +/-   ##
==========================================
+ Coverage   61.11%   61.22%   +0.11%     
==========================================
  Files          37       37              
  Lines        6061     6094      +33     
==========================================
+ Hits         3704     3731      +27     
- Misses       2357     2363       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClaudeHu
Copy link
Member

@ClaudeHu please test this and confirm it meets your needs. See above for differences between wig and npy start positions.

Now the values from different output format are consistent. Tested with with geniml.universe in progress, and the arrays read from .bw (converted by wig2bigwig) and .npy are identical. Thanks!

Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@nleroy917
Copy link
Member

@donaldcampbelljr While youre at it, do you want to comment out the R-CMD-check-devel from the test matrix, or should we do that directly on dev?

@donaldcampbelljr
Copy link
Member Author

@donaldcampbelljr While youre at it, do you want to comment out the R-CMD-check-devel from the test matrix, or should we do that directly on dev?

Done!

@donaldcampbelljr donaldcampbelljr merged commit ce0967a into dev Jan 10, 2025
@donaldcampbelljr donaldcampbelljr deleted the dev_64 branch January 10, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uniwig output inconsistency: npy and wig
3 participants