-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for #64 and #65 #66
Conversation
@ClaudeHu please test this and confirm it meets your needs. See above for differences between wig and npy start positions. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #66 +/- ##
==========================================
+ Coverage 61.11% 61.22% +0.11%
==========================================
Files 37 37
Lines 6061 6094 +33
==========================================
+ Hits 3704 3731 +27
- Misses 2357 2363 +6 ☔ View full report in Codecov by Sentry. |
Now the values from different output format are consistent. Tested with with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
@donaldcampbelljr While youre at it, do you want to comment out the |
Done! |
Fixes #64
Adds enhancement #65
For #64, note that the start and core wiggles will be shifted by 1 since we are converting from bed files(0 based) to wiggles (1 based). The npy files are not shifted so the start and core positions will be 1 less than the wiggle counter parts.
However, because a bed file's end positions are 1 based, no shifting is done for the ends. Therefore, the npy and wig start positions for the end files should be the same.