Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to support dbt-core v1.2.0 #127

Closed
5 tasks
dataders opened this issue Jul 14, 2022 · 2 comments
Closed
5 tasks

upgrade to support dbt-core v1.2.0 #127

dataders opened this issue Jul 14, 2022 · 2 comments

Comments

@dataders
Copy link
Contributor

We've just published the release cut of dbt-core 1.2.0, dbt-core 1.2.0rc1 (PyPI | GitHub release notes).

dbt-labs/dbt-core#5468 is an open discussion with more detailed information, and dbt-labs/dbt-core#5474 is for keeping track of the communities progress on releasing 1.2.0

Below is a checklist of work that would enable a successful 1.2.0 release of your adapter.

  • migrate necessary cross-db macros into adapter and ensure they're tested accordingly
  • remove any copy-and-pasted materialization (if your adapter inherits from another adapter)
  • add new basic tests BaseDocsGenerate and BaseDocsGenReferences
  • consider checking and testing support for Python 3.10

dbt-labs/dbt-core#5432 might make it into the second release cut in the next week, in which case, you'll also might want to:

  • implement method and tests for connection retry logic
This was referenced Jul 15, 2022
Closed
Closed
Merged
Merged
Merged
ueshin added a commit that referenced this issue Jul 18, 2022
@ueshin
Add Python 3.10 to CI (#132)
b5c4468 
### Description

Adds Python 3.10 to CI as per an item from #127.
ueshin added a commit that referenced this issue Jul 18, 2022
@ueshin
[1.2] Add Python 3.10 to CI (#133)
4b6099c 
### Description

Adds Python 3.10 to CI as per an item from #127.
ueshin added a commit that referenced this issue Jul 21, 2022
@ueshin
Add new basic tests TestDocsGenerateDatabricks and TestDocsGenReferen…
7e15f1e 
…cesDatabricks (#134)

### Description

Adds new basic tests `TestDocsGenerateDatabricks` and `TestDocsGenReferencesDatabricks` based on `BaseDocsGenerate` and `BaseDocsGenReferences` respectively as per an item from #127.
ueshin added a commit that referenced this issue Jul 21, 2022
@ueshin
Add new basic tests TestDocsGenerateDatabricks and TestDocsGenReferen…
f4bb861 
…cesDatabricks (#134)

### Description

Adds new basic tests `TestDocsGenerateDatabricks` and `TestDocsGenReferencesDatabricks` based on `BaseDocsGenerate` and `BaseDocsGenReferences` respectively as per an item from #127.
@ueshin ueshin mentioned this issue Jul 22, 2022
Merged
This was referenced Aug 10, 2022
Merged
Closed
@owlas
Copy link

owlas commented Sep 13, 2022

Is this resolved since there is now a release 1.2.2 ? https://github.com/databricks/dbt-databricks/releases/tag/v1.2.2

@ueshin
Copy link
Collaborator

ueshin commented Sep 13, 2022

@owlas Oh, yes, thanks for the reminder. Let me close this.

@ueshin ueshin closed this as completed Sep 13, 2022
ueshin added a commit that referenced this issue Dec 21, 2022
@ueshin
Apply connection retry refactor, add defaults with exponential backoff (
23725ae 
#137)

### Description

Applies connection retry refactor, add defaults with exponential backoff as per an item from #127.

- Refactors retry logic to use `retry_connection` from core.
- Adds consistent defaults with other adpaters:
  - if `connect_retries` and `connect_timeout` are not specified: 1 retry after 1s
  - if `connect_retries` is specified but `connect_timeout` is not, it will use exponential backoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ueshin @dataders @owlas