Drop databricks-sql-connector 1.0. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonwang-db
approved these changes
Jun 9, 2022
| if parse(dbsql.__version__) < parse("2.0"): | ||
| session_configs = creds.session_properties or {} | ||
| if creds.database: | ||
| session_configs[CATALOG_KEY_IN_SESSION_PROPERTIES] = creds.database |
There was a problem hiding this comment.
Will the 2.0 and above version still support CATALOG_KEY_IN_SESSION_PROPERTIES? Should we also update __post_init__?
There was a problem hiding this comment.
You mean DatabricksCredentials.__post_init__, right?
I think we should keep it as is for backward compatibility. Some user might be trying UC with the config.
|
Thanks! merging. |
ueshin
added a commit
to ueshin/dbt-databricks
that referenced
this pull request
Jun 10, 2022
### Description Drops `databricks-sql-connector 1.0` that will be deprecated soon.
ueshin
added a commit
that referenced
this pull request
Jun 15, 2022
### Description Drops `databricks-sql-connector 1.0` that will be deprecated soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drops
databricks-sql-connector 1.0that will be deprecated soon.