Add connection_parameters for databricks-sql-connector connection parameters #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - Add `connection_parameters` for databricks-sql-connector connection parameters ([#135](https://github.com/databricks/dbt-databricks/pull/135)) | ||
| - This can be used to customize the connection by setting the additional parameters. | ||
| - The full parameters are listed at [Databricks SQL Connector for Python](https://docs.databricks.com/dev-tools/python-sql-connector.html#connect-method). | ||
| - Currently, the following parameters are reserved for `dbt-databricks`. Please use the normal credential settings instead. |
There was a problem hiding this comment.
From the documentation, it seems that the only parameter users can set is http_headers? I do see a list of internal arguments that can be set as well https://github.com/databricks/databricks-sql-python/blob/161b94e9c7832fa8393cdff7bc9eac14f6ba840e/src/databricks/sql/client.py#L50
There was a problem hiding this comment.
Yeah, actually the purpose here includes to provide the way to set them, but I'm not sure we should mention the internal parameters here.
There was a problem hiding this comment.
Yea we don't need to mention the internal ones. Just realized the only one that can be set is http_headers (maybe there will be more in the future).
allisonwang-db
approved these changes
Jul 21, 2022
|
Thanks! merging. |
ueshin
added a commit
that referenced
this pull request
Jul 21, 2022
…ameters (#135) ### Description Adds `connection_parameters` as part of credential for `databricks-sql-connector` connection parameters. This can be used to customize the connection by setting additional parameters. The full parameters are listed at [Databricks SQL Connector for Python](https://docs.databricks.com/dev-tools/python-sql-connector.html#connect-method). Currently, the following parameters are reserved for `dbt-databricks`. - server_hostname - http_path - access_token - session_configuration - catalog - schema
ueshin
added a commit
to ueshin/dbt-databricks
that referenced
this pull request
Aug 19, 2022
…ameters (databricks#135) ### Description Adds `connection_parameters` as part of credential for `databricks-sql-connector` connection parameters. This can be used to customize the connection by setting additional parameters. The full parameters are listed at [Databricks SQL Connector for Python](https://docs.databricks.com/dev-tools/python-sql-connector.html#connect-method). Currently, the following parameters are reserved for `dbt-databricks`. - server_hostname - http_path - access_token - session_configuration - catalog - schema
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
connection_parametersas part of credential fordatabricks-sql-connectorconnection parameters.This can be used to customize the connection by setting additional parameters.
The full parameters are listed at Databricks SQL Connector for Python.
Currently, the following parameters are reserved for
dbt-databricks.