-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow "More flexible cluster configuration". #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks for the refactoring.
return self.parsed_model.get( | ||
"cluster_id", | ||
self.credentials.extract_cluster_id( | ||
self.parsed_model.get("http_path", self.credentials.http_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we specify an http_path
that is different from the one in dbt profiles for a Python model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads-up.
Actually I double-checked it and found there is a mistake. I'll update it.
After the update, yes, we can specify http_path
in the Python model config that is different from the one in the profile.
def model(...):
dbt.config(http_path='...')
....
or in dbt_project.yml
file:
models:
- name: my_python_model
config:
http_path: ...
Thanks! merging. |
Description
Follows "More flexible cluster configuration" at dbt-labs/dbt-spark#467.
dbt-spark
's implementationdatabricks-cli