Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add config for pre-commit #756

Closed

Conversation

charlesdong1991
Copy link
Contributor

this is just a draft which kind of shows what i wanna say for #755

i set it to WIP, so feel free to comment and i will change. @ueshin @HyukjinKwon

@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #756 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #756   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          32       32           
  Lines        5667     5667           
=======================================
  Hits         5322     5322           
  Misses        345      345

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db3cf1e...0b3ea23. Read the comment docs.

@charlesdong1991
Copy link
Contributor Author

ahh, just checked .travis.yml, and find out it's building py35, but black only runs on py36 or newer, so pip install will fail..

@ueshin
Copy link
Collaborator

ueshin commented Sep 6, 2019

Maybe we don't need to add it as a dependency, but in that case, definitely we have to add some instruction to install the library for contributors.

@charlesdong1991
Copy link
Contributor Author

yeah, agree... have to remove it, i will add some instructions in CONTRIBUTING.md.

pyproject.toml Outdated
| dist
| venv
)/
'''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a line break at the end of a file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added!
i also notice line length used in koalas is 100, not 88 when reading through contributing.md, also changed in this file.

@HyukjinKwon
Copy link
Member

To me, I'm okie. Seems worth trying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants