-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add config for pre-commit #756
ENH: Add config for pre-commit #756
Conversation
Codecov Report
@@ Coverage Diff @@
## master #756 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 32 32
Lines 5667 5667
=======================================
Hits 5322 5322
Misses 345 345 Continue to review full report at Codecov.
|
ahh, just checked |
Maybe we don't need to add it as a dependency, but in that case, definitely we have to add some instruction to install the library for contributors. |
yeah, agree... have to remove it, i will add some instructions in |
pyproject.toml
Outdated
| dist | ||
| venv | ||
)/ | ||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a line break at the end of a file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, added!
i also notice line length used in koalas is 100, not 88 when reading through contributing.md
, also changed in this file.
To me, I'm okie. Seems worth trying. |
this is just a draft which kind of shows what i wanna say for #755
i set it to WIP, so feel free to comment and i will change. @ueshin @HyukjinKwon