Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Add support for defaults defined in user-specified Avro schema #195

Closed
wants to merge 2 commits into from

Conversation

JoshRosen
Copy link
Contributor

This PR is based on @granturing's #173, with merge-conflicts fixed by @JoshRosen; the original description is as follows:

The current Avro schema option does not seem to support defaults defined in the user-supplied schema. This is causing some confusion for users who are expecting default values but instead are getting null.

This change forces the user-supplied Avro schema to be used for parsing and converting Avro records to Spark SQL Rows or it'll fall-back to the inferred schema if none is supplied.

This is related to #176

@codecov-io
Copy link

codecov-io commented Nov 27, 2016

Current coverage is 91.46% (diff: 100%)

Merging #195 into master will increase coverage by 0.21%

@@             master       #195   diff @@
==========================================
  Files             5          5          
  Lines           320        363    +43   
  Methods         268        307    +39   
  Messages          0          0          
  Branches         52         56     +4   
==========================================
+ Hits            292        332    +40   
- Misses           28         31     +3   
  Partials          0          0          

Powered by Codecov. Last update 15e18ad...170543e

@JoshRosen
Copy link
Contributor Author

This LGTM, so I'm going to merge it in and will cut a release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants