Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken images in setup. Remove unnecessary setup information. #71

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

jonjab
Copy link
Contributor

@jonjab jonjab commented Mar 19, 2024

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Images have been broken in setup since the Workbench implementation. This PR fixes these.

I also removed 3 lines of software from the setup table, since there is a whole second section about GDAL, UDUNITS, etc. right below that table. Feels super redundant.

Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@mikemahoney218
Copy link
Member

Looking at the list of maintainers, it seems to me like no one actually "owns" this repo:

image

That said, the changes look good to me. @datacarpentry/geospatial-curriculum-maintainers , any objections to me merging this?

@likeajumprope likeajumprope self-requested a review March 21, 2024 17:51
Copy link

@likeajumprope likeajumprope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mikemahoney218 mikemahoney218 merged commit fed2af1 into datacarpentry:main Mar 22, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
Auto-generated via {sandpaper}
Source  : fed2af1
Branch  : main
Author  : Michael Mahoney <[email protected]>
Time    : 2024-03-22 16:07:04 +0000
Message : Merge pull request #71 from jonjab/main

Fix broken images in setup. Remove unnecessary setup information.
github-actions bot pushed a commit that referenced this pull request Mar 22, 2024
Auto-generated via {sandpaper}
Source  : 75d5840
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-22 16:08:03 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : fed2af1
Branch  : main
Author  : Michael Mahoney <[email protected]>
Time    : 2024-03-22 16:07:04 +0000
Message : Merge pull request #71 from jonjab/main

Fix broken images in setup. Remove unnecessary setup information.
@mikemahoney218
Copy link
Member

Thanks @jonjab !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants