Truncate golden CosineScores to 6 decimals to reduce noisy diffs. #4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chejennifer
reviewed
Nov 7, 2024
| for i, score in enumerate(part.get('CosineScore', [])): | ||
| part['CosineScore'][i] = float("{:.6f}".format(score)) | ||
| for i, score in enumerate(dbg['props_matching'].get('CosineScore', [])): | ||
| dbg['props_matching']['CosineScore'][i] = float("{:.6f}".format(score)) |
There was a problem hiding this comment.
nit: instead of re-writing this formatting code, could we have a function to format_scores which takes a list of scores and returns a list of formatted scores, so that if we ever want to change how we format the scores, we do it in one place and won't run the risk of missing a spot?
There was a problem hiding this comment.
Agreed! I reformatted to use helper functions, is that better?
chejennifer
reviewed
Nov 7, 2024
| resp_var_to_score[sv] = float("{:.6f}".format(score)) | ||
| truncated_score = _format_score(dbg['sv_matching']['CosineScore'][i]) | ||
| resp_var_to_score[sv] = truncated_score | ||
| dbg['sv_matching']['CosineScore'][i] = truncated_score |
There was a problem hiding this comment.
maybe we can move this part outside of the for loop & just have dbg['sv_matching']['CosineScore'] = _format_scores(dbg['sv_matching'].get('CosineScore', [])
& that way we just need one of the two helper functions & can read score from this formatted list
chejennifer
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces CosineScores to 6 decimals to reduce the diffs that are generated when updating the integration_test goldens.
This is to reduce noise in reviews and should not fundamentally affect the actual tests.