[Fixit Fridays] Make webdriver helpers wait till the element exists, and use those methods in tests #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to use those helpers.
…ht test so it can be reenabled.
gmechali
requested review from
hqpho and
dwnoble
and removed request for
hqpho
dwnoble
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the base_utils find_elem and find_elems methods such that they first have to wait for the element if it's not found. This allows us to remove all that logic from within each test to check if the element exists before trying to find it.
Also fixed how the XPath is sometimes used as the entire path multiple times in the same test.
Moving forward, we should aim to always used find_elem, and find_elems to retrieve elements for webdriver tests.
Will keep working towards moving over the old tests to using this approach.
This also fixed the drought webdriver test which was previously skipped for flakiness. I expect that this will allow us to unskip many other tests as well.