fix(cli): don't use env for container, add example

datahub-project · May 26, 2022 · 10394e0 · 10394e0
1 parent 21f8d4b
commit 10394e0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/docs/how/delete-metadata.md b/docs/how/delete-metadata.md
@@ -61,6 +61,11 @@ _Note: All these commands below support the soft-delete option (`-s/--soft`) as
 datahub delete --env DEV --entity_type dataset
 ```
 
+### Delete all containers for a particular platform
+```
+datahub delete --entity_type container --platform s3
+```
+
 ### Delete all Pipelines and Tasks in the DEV environment
 ```
 datahub delete --env DEV --entity_type "datajob"

diff --git a/metadata-ingestion/src/datahub/cli/cli_utils.py b/metadata-ingestion/src/datahub/cli/cli_utils.py
@@ -352,9 +352,9 @@ def get_urns_by_filter(
     endpoint: str = "/entities?action=search"
     url = gms_host + endpoint
     filter_criteria = []
-    if env:
-        filter_criteria.append({"field": "origin", "value": env, "condition": "EQUAL"})
     entity_type_lower = entity_type.lower()
+    if env and entity_type_lower != "container":
+        filter_criteria.append({"field": "origin", "value": env, "condition": "EQUAL"})
     if (
         platform is not None
         and entity_type_lower == "dataset"