apply review comments

datahub-project · Jul 25, 2024 · 863df15 · 863df15
1 parent e08c6bf
commit 863df15
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/graph/client.py b/metadata-ingestion/src/datahub/ingestion/graph/client.py
@@ -1788,13 +1788,6 @@ class DatahubConfig(BaseModel):
 config_override: Dict = {}
 
 
-def set_env_variables_override_config(url: str, token: Optional[str]) -> None:
-    """Should be used to override the config when using rest emitter"""
-    config_override[ENV_METADATA_HOST_URL] = url
-    if token is not None:
-        config_override[ENV_METADATA_TOKEN] = token
-
-
 def get_details_from_env() -> Tuple[Optional[str], Optional[str]]:
     host = os.environ.get(ENV_METADATA_HOST)
     port = os.environ.get(ENV_METADATA_PORT)

diff --git a/metadata-ingestion/src/datahub/ingestion/sink/datahub_rest.py b/metadata-ingestion/src/datahub/ingestion/sink/datahub_rest.py
@@ -25,10 +25,7 @@
     WriteCallback,
 )
 from datahub.ingestion.api.workunit import MetadataWorkUnit
-from datahub.ingestion.graph.client import (
-    DatahubClientConfig,
-    set_env_variables_override_config,
-)
+from datahub.ingestion.graph.client import DatahubClientConfig
 from datahub.metadata.com.linkedin.pegasus2avro.mxe import (
     MetadataChangeEvent,
     MetadataChangeProposal,
@@ -122,7 +119,6 @@ def __post_init__(self) -> None:
         )
         self.report.max_threads = self.config.max_threads
         logger.debug("Setting env variables to override config")
-        set_env_variables_override_config(self.config.server, self.config.token)
         logger.debug("Setting gms config")
         set_gms_config(gms_config)