Skip to content

Commit

Permalink
docs(ingest/looker): fix typos + update lookml github action example (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
hsheth2 authored Dec 30, 2022
1 parent b967722 commit e9176d2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion metadata-ingestion/docs/sources/looker/looker_pre.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
### Pre-Requisites
### Prerequisites

#### Set up the right permissions
You need to provide the following permissions for ingestion to work correctly.
Expand Down
11 changes: 5 additions & 6 deletions metadata-ingestion/docs/sources/looker/lookml_pre.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
### Pre-requisites
### Prerequisites

#### [Recommended] Create a GitHub Deploy Key

Expand Down Expand Up @@ -69,15 +69,14 @@ You need to set up the following secrets in your GitHub repository to get this w
- LOOKER_CLIENT_ID: A provisioned Looker Client ID
- LOOKER_CLIENT_SECRET: A provisioned Looker Client Secret

```
```yml
name: lookml metadata upload
on:
# Note that this action only runs on pushes to your main branch. If you want to also
# run on pull requests, we'd recommend running datahub ingest with the `--dry-run` flag.
push:
branches:
- main
paths-ignore:
- "docs/**"
- "**.md"
release:
types: [published, edited]
workflow_dispatch:
Expand All @@ -90,7 +89,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: '3.10'
- name: Run LookML ingestion
run: |
pip install 'acryl-datahub[lookml,datahub-rest]'
Expand Down

0 comments on commit e9176d2

Please sign in to comment.