Skip to content

Commit

Permalink
fix(ingestion): fix mypy errors in metabase source
Browse files Browse the repository at this point in the history
  • Loading branch information
remisalmon committed Jan 13, 2023
1 parent c7504c9 commit ec11ba8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions metadata-ingestion/src/datahub/ingestion/source/metabase.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from datetime import datetime, timezone
from functools import lru_cache
from typing import Dict, Iterable, Optional
from typing import Dict, Iterable, List, Optional

import dateutil.parser as dp
import pydantic
Expand Down Expand Up @@ -436,7 +436,7 @@ def construct_card_custom_properties(self, card_details: dict) -> Dict:

return custom_properties

def get_datasource_urn(self, card_details: dict):
def get_datasource_urn(self, card_details: dict) -> Optional[List]:
(
platform,
database_name,
Expand Down Expand Up @@ -492,7 +492,7 @@ def get_datasource_urn(self, card_details: dict):
return None

if platform == "snowflake":
source_tables = [i.lower() for i in source_tables]
source_tables = set(i.lower() for i in source_tables)

# Create dataset URNs
dataset_urn = [
Expand Down

0 comments on commit ec11ba8

Please sign in to comment.