Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): support alternate hashing algorithm for doc id #10423
feat(config): support alternate hashing algorithm for doc id #10423
Changes from 49 commits
151c34f
bdb04e6
19ca916
8ce0ab7
a3460bf
7af93c5
d127d8c
b320b22
d980b52
b67593a
30a8781
6e7f128
8a9ba47
f598f3f
ec66c70
cfb96eb
be75dbe
f5aa13f
31f8466
00ca5c0
26fe2af
7942b21
58ef4b0
50b80ad
794d9f5
183f29a
9a90977
27c7e55
0da6a69
3d08df5
c3054f2
e1b8a6a
f6cf681
e3a1a16
09353e1
c2f7992
d084f22
36de029
bb62edb
1d4aeef
d81d314
cb10f26
6a4b10d
9d17ba2
6d83634
83535dc
1a815ee
b425468
7870ef1
95c9d44
7dda052
e2f0be7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Ensure the
idHashAlgo
configuration is utilized in theTimeseriesAspectTransformer
class.The
idHashAlgo
field is set using the@Value
annotation, but there is no evidence that it is being used in the transformation logic. This could lead to the hash algorithm configuration not being applied as intended.metadata-io/src/main/java/com/linkedin/metadata/timeseries/transformer/TimeseriesAspectTransformer.java
: Ensure theidHashAlgo
field is used in the transformation methods.Analysis chain
LGTM! But verify the usage of the new configuration.
The changes to set the hash algorithm to "MD5" in the
upsertDocument
method are correct.However, ensure that the new configuration is correctly utilized throughout the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 612
Script:
Length of output: 148
Script:
Length of output: 144
Script:
Length of output: 411
Script:
Length of output: 159