Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix in openapi params #10474

Merged
merged 2 commits into from
May 9, 2024
Merged

bugfix in openapi params #10474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb66238
bugfix in openapi params
kevin1chun May 9, 2024
a04ef88
fix default
kevin1chun May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ervice/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/OpenAPIV3Generator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ private static PathItem buildListEntityPath(final EntitySpec entity) {
.parameters(
List.of(
new Parameter()
.in(NAME_ASYNC)
.in(NAME_QUERY)
.name("async")
.description("Use async ingestion for high throughput.")
.schema(new Schema().type(TYPE_BOOLEAN)._default(true)),
Expand Down Expand Up @@ -412,7 +412,8 @@ private static Parameter buildParameterSchema(
final Schema schema =
new Schema()
.type(TYPE_ARRAY)
.items(new Schema().type(TYPE_STRING)._enum(aspectNames)._default(aspectNames));
.items(new Schema().type(TYPE_STRING)._enum(aspectNames)
._default(aspectNames.stream().findFirst().orElse(null)));
return new Parameter()
.in(NAME_QUERY)
.name("aspects")
Expand Down
Loading