Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/snowflake): avoid overfetching schemas from datahub #10527

Merged
merged 2 commits into from
Jun 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,18 @@ def __init__(self, ctx: PipelineContext, config: SnowflakeV2Config):
platform=self.platform,
platform_instance=self.config.platform_instance,
env=self.config.env,
graph=self.ctx.graph,
graph=(
hsheth2 marked this conversation as resolved.
Show resolved Hide resolved
# If we're ingestion schema metadata for tables/views, then we will populate
# schemas into the resolver as we go. We only need to do a bulk fetch
# if we're not ingesting schema metadata as part of ingestion.
self.ctx.graph
if not (
self.config.include_technical_schema
and self.config.include_tables
and self.config.include_views
)
else None
),
generate_usage_statistics=False,
generate_operations=False,
)
Expand Down Expand Up @@ -1242,7 +1253,7 @@ def gen_schema_metadata(
foreignKeys=foreign_keys,
)

if self.aggregator and self.config.parse_view_ddl:
if self.aggregator:
self.aggregator.register_schema(urn=dataset_urn, schema=schema_metadata)

return schema_metadata
Expand Down
Loading