Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(glossary): add note for github action for glossary #10687

Merged
merged 2 commits into from
Jun 12, 2024
Merged

doc(glossary): add note for github action for glossary #10687

merged 2 commits into from
Jun 12, 2024

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs labels Jun 12, 2024
pedro93
pedro93 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra file (dataset.yaml) that is empty. Please remove that.

@anshbansal anshbansal added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 12, 2024
@anshbansal anshbansal merged commit 6f9de6a into master Jun 12, 2024
27 checks passed
@anshbansal anshbansal deleted the ab-add-git-action branch June 12, 2024 12:03
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@anshbansal @sleeperdeep
doc(glossary): add note for github action for glossary (datahub-proje…
e1fe8b6 
…ct#10687)
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@anshbansal @yoonhyejin
doc(glossary): add note for github action for glossary (#10687)
5fdeaf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @pedro93