-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest/mssql): remove lower() method from sql_common get_db_name #10773
Merged
hsheth2
merged 15 commits into
datahub-project:master
from
sleeperdeep:feature/fix_sql_common_get_db_name_method
Sep 3, 2024
Merged
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fff3ec0
fix(ingest/mssql): remove lower() method from sql_common get_db_name
sleeperdeep ca8f3b1
fix(ingest/mssql): remove lower() method from sql_common get_db_name;…
sleeperdeep 07394d1
fix(ingest/mssql): remove lower() method from sql_common get_db_name;…
sleeperdeep a48d618
fix(ingest/mssql): remove lower() method from sql_common get_db_name;…
sleeperdeep 1da9093
fix(ingest/mssql): remove lower() method from sql_common get_db_name
sleeperdeep 6ea7f80
fix(ingest/mssql): remove lower() method from sql_common get_db_name;…
sleeperdeep 369018f
fix(ingest/mssql): remove lower() method from sql_common get_db_name;…
sleeperdeep 3a9550b
fix(ingest/mssql): remove lower() method from sql_common get_db_name;…
sleeperdeep 4a23a7d
Merge branch 'lowercase_detached' into feature/fix_sql_common_get_db_…
sleeperdeep 574e980
Merge branch 'lower_detached' into feature/fix_sql_common_get_db_name…
sleeperdeep 90d5d4c
Merge branch 'master' into feature/fix_sql_common_get_db_name_method
sleeperdeep 09aea86
revert to prev state
sleeperdeep e3e324f
fix issue with vertica golden file
sleeperdeep bd3d14d
fix issue with golden files
sleeperdeep 4c423f7
return path to prev state
sleeperdeep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -19,6 +19,17 @@ This file documents any backwards-incompatible changes in DataHub and assists pe | |||||
## Next | ||||||
|
||||||
### Breaking Changes | ||||||
- #9857 (#10773) `lower` method was removed from `get_db_name` of `SQLAlchemySource` class. This change will affect the urns of all related to `SQLAlchemySource` entities. | ||||||
|
||||||
Old `urn`, where `data_base_name` is `Some_Database`: | ||||||
``` | ||||||
- urn:li:dataset:(urn:li:dataPlatform:paltform,some_database.schema.entitie,ENV) | ||||||
``` | ||||||
New `urn`, where `data_base_name` is `Some_Database`: | ||||||
``` | ||||||
- urn:li:dataset:(urn:li:dataPlatform:paltform,Some_Database.schema.entitie,ENV) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed |
||||||
``` | ||||||
Re-running with stateful ingestion should automatically clear up the entities with old URNS and add entities with new URNs, therefore not duplicating the containers or jobs. | ||||||
|
||||||
### Potential Downtime | ||||||
|
||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change the example to be of dataJob as only dataJob and container URNs have changed and not that of dataset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.