Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion/lookml): enable stack-trace in lookml logs #10971

Merged
merged 13 commits into from
Jul 31, 2024
Merged
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,12 @@ def _load_viewfile(
with open(path) as file:
raw_file_content = file.read()
except Exception as e:
self.reporter.failure("Failed to read lkml file", path, exc=e)
self.reporter.failure(
title="LKML File Loading Error",
message=f"Failed to read lkml file {path}",
sid-acryl marked this conversation as resolved.
Show resolved Hide resolved
exc=e,
log=True,
sid-acryl marked this conversation as resolved.
Show resolved Hide resolved
sid-acryl marked this conversation as resolved.
Show resolved Hide resolved
)
self.viewfile_cache[path] = None
return None
try:
Expand All @@ -86,7 +91,17 @@ def _load_viewfile(
self.viewfile_cache[path] = looker_viewfile
return looker_viewfile
except Exception as e:
self.reporter.failure("Failed to parse lkml file", path, exc=e)
self.reporter.failure(
title="LKML File Parsing Error",
message=f"Failed to parse lookml file {path}",
exc=e,
log=True,
)

logger.debug(f"Raw file content for path {path}")

logger.debug(raw_file_content)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this one debug log message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are already debug.

Copy link
Collaborator

@hsheth2 hsheth2 Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant one debug call instead of two


self.viewfile_cache[path] = None
return None

Expand Down
Loading