feat(build): remove base-requirements.txt #11238

hsheth2 · 2024-08-23T21:36:07Z

We want the ingestion-base image to be as slim as possible - that means not installing packages that we aren't sure will be used by images built on top of this one. We had previously needed this to improve build times since pip was slow, but our migration to uv obviates the need. This should also help slim down the datahub-actions container.

This PR also sets up depot.dev. This helps us avoid using qemu for arm emulation, which slows down our builds significantly.

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

We want the ingestion-base image to be as slim as possible - that means not installing packages that we aren't sure will be used by images built on top of this one. This should also help slim down the datahub-actions container.

coderabbitai · 2024-08-23T21:36:13Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

david-leifker

Unfortunately, this adds significant build time whenever metadata-ingestion is changed. Currently this time cost is only paid when the base requirements.txt is updated.

For the slim ingestion image the build runs for 51 minutes and for full it runs 1 hour and 8 minutes.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

actionlint

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:11:51: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 73 in b3727c0

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 89 in b3727c0

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:45: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 100 in b3727c0

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:45: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 111 in b3727c0

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:118: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 552 in b3727c0

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_base_change == 'true' && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:128: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 594 in b3727c0

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_base_change == 'true' && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:123: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 635 in b3727c0

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_base_change == 'true' && needs.setup.outputs.unique_full_tag || 'head' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:123: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 690 in b3727c0

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_change == 'true' && needs.setup.outputs.unique_slim_tag || 'head-slim' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:1:113: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 776 in b3727c0

    
           run: echo "tag=${{ needs.setup.outputs.ingestion_change == 'true' && needs.setup.outputs.unique_tag || 'head' }}" >> $GITHUB_OUTPUT

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 818 in b3727c0

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:4:63: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 818 in b3727c0

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:6:95: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 818 in b3727c0

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:8:24: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 818 in b3727c0

run: |

[actionlint] _{reported by reviewdog 🐶}
property "short_sha" is not defined in object type {backend_change: string; backend_only: string; branch_name: string; docker-login: string; elasticsearch_setup_change: string; frontend_change: string; frontend_only: string; full_tag: string; ingestion_base_change: string; ingestion_change: string; ingestion_only: string; kafka_setup_change: string; mysql_setup_change: string; postgres_setup_change: string; pr-publish: string; publish: string; python_release_version: string; repository_name: string; slim_tag: string; smoke_test_change: string; tag: string; unique_full_tag: string; unique_slim_tag: string; unique_tag: string} [expression]

datahub/.github/workflows/docker-unified.yml

Line 1065 in b3727c0

    
           message: '{ "command": "git-sync", "args" : {"repoName": "${{ needs.setup.outputs.repository_name }}", "repoOrg": "${{ github.repository_owner }}", "repoBranch": "${{ needs.setup.outputs.branch_name }}", "repoShaShort": "${{ needs.setup.outputs.short_sha }}" }}'

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

actionlint

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:4:63: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 818 in febba8b

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:6:95: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 818 in febba8b

run: |

[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2086:info:8:24: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 818 in febba8b

run: |

[actionlint] _{reported by reviewdog 🐶}
property "short_sha" is not defined in object type {backend_change: string; backend_only: string; branch_name: string; docker-login: string; elasticsearch_setup_change: string; frontend_change: string; frontend_only: string; full_tag: string; ingestion_base_change: string; ingestion_change: string; ingestion_only: string; kafka_setup_change: string; mysql_setup_change: string; postgres_setup_change: string; pr-publish: string; publish: string; python_release_version: string; repository_name: string; slim_tag: string; smoke_test_change: string; tag: string; unique_full_tag: string; unique_slim_tag: string; unique_tag: string} [expression]

datahub/.github/workflows/docker-unified.yml

Line 1065 in febba8b

    
           message: '{ "command": "git-sync", "args" : {"repoName": "${{ needs.setup.outputs.repository_name }}", "repoOrg": "${{ github.repository_owner }}", "repoBranch": "${{ needs.setup.outputs.branch_name }}", "repoShaShort": "${{ needs.setup.outputs.short_sha }}" }}'

github-actions · 2024-08-29T20:17:49Z

.github/workflows/docker-unified.yml

@@ -68,23 +72,23 @@ jobs:
        id: tag
        run: |


[actionlint] _{reported by reviewdog 🐶}
shellcheck reported issue in this script: SC2129:style:2:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]

david-leifker · 2024-08-29T20:37:10Z

docker/datahub-ingestion/Dockerfile

 RUN sed -i.bak "s/__version__ = \"1\!0.0.0.dev0\"/__version__ = \"$(echo $RELEASE_VERSION|sed s/-/+/)\"/" src/datahub/__init__.py && \
    sed -i.bak "s/__version__ = \"1\!0.0.0.dev0\"/__version__ = \"$(echo $RELEASE_VERSION|sed s/-/+/)\"/" airflow-plugin/src/datahub_airflow_plugin/__init__.py && \
    cat src/datahub/__init__.py | grep __version__ && \
    cat airflow-plugin/src/datahub_airflow_plugin/__init__.py | grep __version__

 FROM base AS slim-install

-RUN uv pip install --no-cache -e ".[base,datahub-rest,datahub-kafka,snowflake,bigquery,redshift,mysql,postgres,hive,clickhouse,glue,dbt,looker,lookml,tableau,powerbi,superset,datahub-business-glossary]"
+RUN --mount=type=cache,target=/datahub-ingestion/.cache/uv,uid=1000,gid=1000 \


Curious as to why this one is still /datahub-ingestion while it seems to be changed everywhere else?

Maybe the change was separating the metadata-ingestion source from the user's home directory and the cache is expected in the home directory.

I think the WORKDIR should be restored after install.

Yup that's it

/datahub-ingestion is the user's home directory - there's nothing in here other than dotfiles and the uv cache

/metadata-ingestion has the code from the metadata-ingestion directory

I can make it restore the workdir

github-actions · 2024-08-29T22:27:39Z

.github/workflows/docker-unified.yml

[actionlint] _{reported by reviewdog 🐶}
property "short_sha" is not defined in object type {backend_change: string; backend_only: string; branch_name: string; docker-login: string; elasticsearch_setup_change: string; frontend_change: string; frontend_only: string; full_tag: string; ingestion_base_change: string; ingestion_change: string; ingestion_only: string; kafka_setup_change: string; mysql_setup_change: string; postgres_setup_change: string; pr-publish: string; publish: string; python_release_version: string; repository_name: string; slim_tag: string; smoke_test_change: string; tag: string; unique_full_tag: string; unique_slim_tag: string; unique_tag: string} [expression]

datahub/.github/workflows/docker-unified.yml

Line 1071 in 16f834e

message: '{ "command": "git-sync", "args" : {"repoName": "${{ needs.setup.outputs.repository_name }}", "repoOrg": "${{ github.repository_owner }}", "repoBranch": "${{ needs.setup.outputs.branch_name }}", "repoShaShort": "${{ needs.setup.outputs.short_sha }}" }}'

feat(build): remove base-requirements.txt

30b59c7

We want the ingestion-base image to be as slim as possible - that means not installing packages that we aren't sure will be used by images built on top of this one. This should also help slim down the datahub-actions container.

hsheth2 requested a review from david-leifker August 23, 2024 21:36

github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Aug 23, 2024

tweak from command

e3f196e

vercel bot deployed to Preview August 23, 2024 22:11 View deployment

bump docker image revisions - test image builds

5db0271

david-leifker added the publish-docker label Aug 26, 2024

vercel bot deployed to Preview August 26, 2024 18:13 View deployment

david-leifker requested changes Aug 26, 2024

View reviewed changes

use uv cache

c81d7cd

vercel bot deployed to Preview August 27, 2024 18:45 View deployment

hsheth2 added 2 commits August 27, 2024 12:58

more aggressive caching w/ gha mode=max

2b8cbd8

tweak gha cache

e7e9e43

vercel bot deployed to Preview August 27, 2024 20:32 View deployment

hsheth2 added 2 commits August 29, 2024 12:36

Merge branch 'master' into remove-base-requirements

d8eda0e

test out depot.dev

b3727c0

github-actions bot reviewed Aug 29, 2024

View reviewed changes

fix

febba8b

github-actions bot reviewed Aug 29, 2024

View reviewed changes

hsheth2 added 2 commits August 29, 2024 13:02

improve cache loading

c9833e6

fix shellchell

d00c8dd

github-actions bot reviewed Aug 29, 2024

View reviewed changes

david-leifker reviewed Aug 29, 2024

View reviewed changes

vercel bot deployed to Preview August 29, 2024 20:37 View deployment

make depot-based builds opt-in

16f834e

github-actions bot reviewed Aug 29, 2024

View reviewed changes

hsheth2 added 2 commits August 29, 2024 15:28

fix bug

15e9172

tweak paths

9ce39c4

vercel bot deployed to Preview August 29, 2024 23:02 View deployment

david-leifker approved these changes Aug 30, 2024

View reviewed changes

david-leifker merged commit c4bc34f into master Aug 30, 2024
49 checks passed

david-leifker deleted the remove-base-requirements branch August 30, 2024 03:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(build): remove base-requirements.txt #11238

feat(build): remove base-requirements.txt #11238

hsheth2 commented Aug 23, 2024 •

edited

Loading

coderabbitai bot commented Aug 23, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

david-leifker left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot Aug 29, 2024

david-leifker Aug 29, 2024

david-leifker Aug 29, 2024 •

edited

Loading

hsheth2 Aug 29, 2024

github-actions bot Aug 29, 2024

feat(build): remove base-requirements.txt #11238

feat(build): remove base-requirements.txt #11238

Conversation

hsheth2 commented Aug 23, 2024 • edited Loading

Checklist

coderabbitai bot commented Aug 23, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

david-leifker left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 29, 2024

Choose a reason for hiding this comment

david-leifker Aug 29, 2024

Choose a reason for hiding this comment

david-leifker Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

hsheth2 Aug 29, 2024

Choose a reason for hiding this comment

github-actions bot Aug 29, 2024

Choose a reason for hiding this comment

hsheth2 commented Aug 23, 2024 •

edited

Loading

coderabbitai bot commented Aug 23, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

david-leifker Aug 29, 2024 •

edited

Loading