fix(ingest/snowflake): Update snowflake_utils.py to account for iceberg tables

[alisa-aylward-toast]

Lineage for Iceberg tables isn't fully configured since this filter omits them

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• New Features

  • Added support for "iceberg table" dataset type in the filtering process.

• Bug Fixes

  • Corrected indentation in the dataset pattern validation method for improved control flow.

[coderabbitai]

Walkthrough

The changes involve the addition of a new constant, SnowflakeObjectDomain.ICEBERG_TABLE, to the SnowflakeFilter class's is_dataset_pattern_allowed method in the snowflake_utils.py file. This constant enables the method to recognize "iceberg table" as a valid dataset type. Additionally, the indentation of the return False statement has been corrected to ensure proper control flow. A new constant was also declared in the constants.py file, with no other significant changes to the logic or control flow.

Changes

File Path	Change Summary
metadata-ingestion/src/datahub/ingestion/source/snowflake/snowflake_utils.py	Added constant SnowflakeObjectDomain.ICEBERG_TABLE to is_dataset_pattern_allowed method; corrected indentation of return False.
metadata-ingestion/src/datahub/ingestion/source/snowflake/constants.py	Declared new constant SnowflakeObjectDomain.ICEBERG_TABLE.

Poem

🐰 In the land of data, where tables gleam,
A new type has joined the filtering team!
Icebergs now dance in the dataset's flow,
With proper returns, our logic will glow.
Hooray for the changes, let’s hop and rejoice,
For every new constant, we celebrate with voice! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[maggiehays]

@coderabbitai summary