Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hudi): add hudi platform to the list of default platforms #11993

Merged
merged 4 commits into from
Dec 3, 2024
Merged

feat(hudi): add hudi platform to the list of default platforms #11993

merged 4 commits into from
Dec 3, 2024

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Nov 30, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 30, 2024
david-leifker
david-leifker approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootstrap config looks good!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 3, 2024
chriscollins3456
chriscollins3456 reviewed Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look correct but it looks like the resolution of the hudi logo is pretty small so it could be kind of pixelated. also, the PNG doesn't have a truly clear background, it has a white square around the logo which is what's making it look a little off in the UI i think

@shirshanka shirshanka merged commit eef9759 into datahub-project:master Dec 3, 2024
39 of 42 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@shirshanka @chriscollins3456 @sleeperdeep
feat(hudi): add hudi platform to the list of default platforms (datah…
1486d83 
…ub-project#11993)

Co-authored-by: Chris Collins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shirshanka @chriscollins3456 @david-leifker