-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest/pulsar): handle Avro schema with missing namespace or name #12058
fix(ingest/pulsar): handle Avro schema with missing namespace or name #12058
Conversation
fix: pulsar ingestion fails when Avro schema is missing namespace or name Problem Description The root cause is that the code attempts to concatenate these fields without checking if they exist: Fix Description Modified Files |
Co-authored-by: Sergio Gómez Villamor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good - I accepted @sgomezvillamor's suggestion
… fix-pulsar-ingestion-fails # Conflicts: # metadata-ingestion/src/datahub/ingestion/source/pulsar.py
self.schema_name = "null" | ||
if avro_schema.get("namespace") and avro_schema.get("name"): | ||
self.schema_name = ( | ||
avro_schema.get("namespace") + "." + avro_schema.get("name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest build failed because of a format issue, which should be fixed with:
avro_schema.get("namespace") + "." + avro_schema.get("name") | |
avro_schema.get("namespace") + "." + avro_schema.get("name") |
5946558
into
datahub-project:master
fix: pulsar ingestion fails when Avro schema is missing namespace or name
Checklist