fix(ingest/snowflake): handle dots in snowflake table names #12105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
sgomezvillamor
approved these changes
Dec 12, 2024
Comment on lines
+187
to
+199
| def _split_qualified_name(qualified_name: str) -> List[str]: | ||
| """ | ||
| Split a qualified name into its constituent parts. | ||
|
|
||
| >>> _split_qualified_name("db.my_schema.my_table") | ||
| ['db', 'my_schema', 'my_table'] | ||
| >>> _split_qualified_name('"db"."my_schema"."my_table"') | ||
| ['db', 'my_schema', 'my_table'] | ||
| >>> _split_qualified_name('TEST_DB.TEST_SCHEMA."TABLE.WITH.DOTS"') | ||
| ['TEST_DB', 'TEST_SCHEMA', 'TABLE.WITH.DOTS'] | ||
| >>> _split_qualified_name('TEST_DB."SCHEMA.WITH.DOTS".MY_TABLE') | ||
| ['TEST_DB', 'SCHEMA.WITH.DOTS', 'MY_TABLE'] | ||
| """ |
There was a problem hiding this comment.
This function seems quite generic and not specific to Snowflake. Could it be moved to a some shared utils file?
Also, consider turning the docstring into a proper unit test.
There was a problem hiding this comment.
because of doctest, the docstring is a unit test :)
if we find another system that formats table names the same way, we can move this util into a shared utils location
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
hsheth2
added a commit
that referenced
this pull request
Dec 12, 2024
5 tasks
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist