Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): tighten Source.create type annotations #12325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 11, 2025

Supersedes #8620

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 11, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 11, 2025
@@ -122,11 +122,6 @@ def __init__(self, config: DeltaLakeSourceConfig, ctx: PipelineContext):
config_report,
)

@classmethod
def create(cls, config_dict: dict, ctx: PipelineContext) -> "Source":
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the config_class decorator auto-generates this method, so we can just remove it here

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ngestion/src/datahub/ingestion/source/demo_data.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...data-ingestion/src/datahub/ingestion/api/source.py 99.15% <100.00%> (ø)
.../src/datahub/ingestion/source/delta_lake/source.py 92.00% <ø> (-0.21%) ⬇️
.../src/datahub/ingestion/source/fivetran/fivetran.py 94.54% <100.00%> (-0.20%) ⬇️
...ub/ingestion/source/kafka_connect/kafka_connect.py 92.15% <100.00%> (-0.20%) ⬇️
...ingestion/src/datahub/ingestion/source/metabase.py 85.30% <100.00%> (-0.19%) ⬇️
...a-ingestion/src/datahub/ingestion/source/mlflow.py 100.00% <ø> (ø)
...ata-ingestion/src/datahub/ingestion/source/nifi.py 89.95% <ø> (-0.07%) ⬇️
...a-ingestion/src/datahub/ingestion/source/redash.py 71.70% <ø> (+0.23%) ⬆️
...datahub/ingestion/source/snowflake/snowflake_v2.py 89.08% <ø> (-0.16%) ⬇️
...ingestion/src/datahub/ingestion/source/superset.py 80.13% <100.00%> (-0.27%) ⬇️
... and 2 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9897804...bca63db. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant