Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion/s3): ignore depth mismatched path #12326

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(ingestion/s3): ignore depth mismatched path #12326

wants to merge 1 commit into from
+92 −21

Conversation

eagle-25
Copy link
Contributor

@eagle-25 eagle-25 commented Jan 12, 2025 •
edited
Loading

Summary

Changes

Background

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jan 12, 2025
@eagle-25 eagle-25 force-pushed the feat/s3/ingestion/ignore-depth-mismatched-path branch 2 times, most recently from e6d168e to d5a4387 Compare January 12, 2025 15:37
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...estion/src/datahub/ingestion/source/aws/s3_util.py 92.00% <100.00%> (+0.33%) ⬆️
...ngestion/src/datahub/ingestion/source/s3/source.py 86.85% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9897804...a2690ac. Read the comment docs.

@eagle-25 eagle-25 force-pushed the feat/s3/ingestion/ignore-depth-mismatched-path branch 3 times, most recently from db78b88 to c63a02e Compare January 12, 2025 15:47
@eagle-25 eagle-25 force-pushed the feat/s3/ingestion/ignore-depth-mismatched-path branch from c63a02e to a2690ac Compare January 12, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eagle-25