fix(ingest): avoid multiprocessing "fork" start method #12543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use threads in a variety of places within our CLI. The multiprocessing "fork" start method is not safe to use with threads. MacOS and Windows already default to "spawn", and Linux will as well starting in Python 3.14. See https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods
This fixes a bug where the classification module would deadlock when using more than one worker process. Reverts #12261, since that workaround is no longer required.
By making changes to both the entrypoint and the classification module, we can ensure that
Pipeline.create(...).run()
, we will not cause any deadlocksEventually it may make sense to use "forkserver" as the default where available, but we can revisit that in the future.
Tested locally.
Checklist