feat(urn-validation): Add UrnValidation PDL annotation

[david-leifker]

• Apply UrnValidation logic to StructuredPropertyDefinition valueType
• Consolidate validation utils to metadata-utils
• Does not apply to RESTATE to allow restoreIndices to function

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

[codecov]

Codecov Report

Attention: Patch coverage is 69.87448% with 72 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...com/linkedin/metadata/utils/UrnValidationUtil.java	50.51%	41 Missing and 7 partials ⚠️
...ory/plugins/SpringStandardPluginConfiguration.java	0.00%	10 Missing ⚠️
...data/aspect/validation/UrnAnnotationValidator.java	93.75%	1 Missing and 4 partials ⚠️
...in/metadata/models/annotation/AnnotationUtils.java	70.00%	1 Missing and 2 partials ⚠️
...ata/models/annotation/UrnValidationAnnotation.java	62.50%	2 Missing and 1 partial ⚠️
.../java/com/linkedin/metadata/models/AspectSpec.java	83.33%	1 Missing ⚠️
...om/linkedin/metadata/models/EntitySpecBuilder.java	88.88%	1 Missing ⚠️
...tadata/models/UrnValidationFieldSpecExtractor.java	94.73%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (57.86%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines	Coverage Δ
...edin/metadata/aspect/utils/DefaultAspectsUtil.java	84.67% <ø> (ø)
...om/linkedin/metadata/entity/EntityServiceImpl.java	79.67% <ø> (ø)
...java/com/linkedin/metadata/entity/EntityUtils.java	77.69% <ø> (ø)
...roject/openapi/v2/controller/EntityController.java	0.00% <ø> (ø)
...roject/openapi/v3/controller/EntityController.java	52.95% <ø> (ø)
...va/com/linkedin/metadata/utils/EntityApiUtils.java	25.00% <ø> (ø)
...din/metadata/utils/EntityRegistryUrnValidator.java	60.00% <ø> (ø)
...nkedin/metadata/utils/RecordTemplateValidator.java	53.84% <ø> (ø)
.../java/com/linkedin/metadata/models/AspectSpec.java	84.37% <83.33%> (-0.11%)	⬇️
...om/linkedin/metadata/models/EntitySpecBuilder.java	68.83% <88.88%> (+0.87%)	⬆️
... and 6 more

... and 7 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7472c53...83b19cb. Read the comment docs.

[pedro93]

Are there plans for it be applied to be required for all urn fields? It would add reference consistency to the metadata graph.

[esteban]

Awesome, @david-leifker!

[david-leifker]

mutations/managing_secrets.js passes locally