Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update local dev guide #12585

Merged
merged 6 commits into from
Feb 14, 2025
Merged

docs: update local dev guide #12585

merged 6 commits into from
Feb 14, 2025

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Feb 10, 2025
@yoonhyejin yoonhyejin marked this pull request as ready for review February 10, 2025 09:19
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 10, 2025
hsheth2
hsheth2 reviewed Feb 10, 2025
View reviewed changes
docs/developers.md Outdated Show resolved Hide resolved
docs/developers.md Outdated Show resolved Hide resolved
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Feb 10, 2025
@yoonhyejin @hsheth2
Update docs/developers.md
f7fc494 
Co-authored-by: Harshal Sheth <[email protected]>
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Feb 11, 2025
@yoonhyejin yoonhyejin requested a review from hsheth2 February 11, 2025 01:01
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Feb 11, 2025
yoonhyejin
yoonhyejin commented Feb 12, 2025
View reviewed changes
docs/developers.md Outdated Show resolved Hide resolved
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Feb 12, 2025
hsheth2
hsheth2 approved these changes Feb 13, 2025
View reviewed changes
docs/developers.md Outdated Show resolved Hide resolved
docs/developers.md Outdated Show resolved Hide resolved
docs/developers.md Outdated Show resolved Hide resolved
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 13, 2025
asikowitz
asikowitz reviewed Feb 13, 2025
View reviewed changes
docs/developers.md Outdated Show resolved Hide resolved
@hsheth2 hsheth2 merged commit 5ba7767 into datahub-project:master Feb 14, 2025
29 checks passed
ttekampe pushed a commit to ttekampe/datahub that referenced this pull request Feb 14, 2025
@yoonhyejin @hsheth2
docs: update local dev guide (datahub-project#12585)
552b205 
Co-authored-by: Harshal Sheth <[email protected]>
ksrinath pushed a commit to ksrinath/datahub that referenced this pull request Feb 14, 2025
@yoonhyejin @hsheth2 @ksrinath
docs: update local dev guide (datahub-project#12585)
f78e3e1 
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz left review comments

@hsheth2 hsheth2 hsheth2 approved these changes

@ryota-cloud ryota-cloud Awaiting requested review from ryota-cloud

Assignees
No one assigned
Labels
docs Issues and Improvements to docs pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoonhyejin @asikowitz @hsheth2