Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web) ingestion page resets when filter updated #12589

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

jayacryl
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
19 1 18 0
View the full list of 1 ❄️ flaky tests
tests.cypress.integration_test::test_run_cypress

Flake rate in main: 17.86% (Passed 23 times, Failed 5 times)

Stack Traces | 1010s run time
auth_session = <tests.utils.TestSessionWrapper object at 0x7fe97085cbe0>

    def test_run_cypress(auth_session):
        # Run with --record option only if CYPRESS_RECORD_KEY is non-empty
        record_key = os.getenv("CYPRESS_RECORD_KEY")
        tag_arg = ""
        test_strategy = os.getenv("TEST_STRATEGY", None)
        if record_key:
            record_arg = " --record "
            batch_number = os.getenv("BATCH_NUMBER")
            batch_count = os.getenv("BATCH_COUNT")
            if batch_number and batch_count:
                batch_suffix = f"-{batch_number}{batch_count}"
            else:
                batch_suffix = ""
            tag_arg = f" --tag {test_strategy}{batch_suffix}"
        else:
            record_arg = " "
    
        print(f"test strategy is {test_strategy}")
        test_spec_arg = ""
        specs_str = ",".join([f"**/{f}" for f in _get_cypress_tests_batch()])
        test_spec_arg = f" --spec '{specs_str}' "
    
        print("Running Cypress tests with command")
        command = f"NO_COLOR=1 npx cypress run {record_arg} {test_spec_arg} {tag_arg}"
        print(command)
        # Add --headed --spec '**/mutations/mutations.js' (change spec name)
        # in case you want to see the browser for debugging
        print_now()
        proc = subprocess.Popen(
            command,
            shell=True,
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
            cwd=f"{CYPRESS_TEST_DATA_DIR}",
        )
        assert proc.stdout is not None
        assert proc.stderr is not None
        stdout = proc.stdout.read()
        stderr = proc.stderr.read()
        return_code = proc.wait()
        print(stdout.decode("utf-8"))
        print("stderr output:")
        print(stderr.decode("utf-8"))
        print("return code", return_code)
        print_now()
>       assert return_code == 0
E       assert 1 == 0

tests/cypress/integration_test.py:250: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 10, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 10, 2025
@jayacryl jayacryl merged commit 60bbedf into master Feb 11, 2025
206 of 216 checks passed
@jayacryl jayacryl deleted the jp--ingestion-sorts-fix branch February 11, 2025 19:42
mihai103 pushed a commit to mihai103/datahub that referenced this pull request Feb 12, 2025
ksrinath pushed a commit to ksrinath/datahub that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants