Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: update pre-commit config #12592

Merged
merged 1 commit into from
Feb 12, 2025
Merged

dev: update pre-commit config #12592

merged 1 commit into from
Feb 12, 2025

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Feb 11, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20409fd...e02798a. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 11, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 11, 2025
hsheth2
hsheth2 reviewed Feb 11, 2025
View reviewed changes
metadata-service/iceberg-catalog/src/integrationTest/integration_test.py
@@ -181,7 +179,7 @@ def _test_basic_view_ops(spark_session):
try:
spark_session.sql("SELECT * FROM test_view")
assert False, "test_view must not exist"
except:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should actually be using pytest.raises(Exception, "expected message")

the way these tests are set up currently does not actually test anything, since the AssertionError would get caught and suppressed by the except block

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in other words - ruff is flagging a real issue

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will let @chakru-r know about that - not a blocker for this PR

@anshbansal anshbansal merged commit 96022f2 into master Feb 12, 2025
217 of 230 checks passed
@anshbansal anshbansal deleted the ab-2025-feb-11-update-pre-commit branch February 12, 2025 05:23
mihai103 pushed a commit to mihai103/datahub that referenced this pull request Feb 12, 2025
@anshbansal
dev: update pre-commit config (datahub-project#12592)
e852ea8
ksrinath pushed a commit to ksrinath/datahub that referenced this pull request Feb 14, 2025
@anshbansal @ksrinath
dev: update pre-commit config (datahub-project#12592)
c5b2aa9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @hsheth2 @david-leifker