Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding annotation option to frontend service #2674

Merged
merged 2 commits into from
Jun 17, 2021
Merged

feat: Adding annotation option to frontend service #2674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc4f987
feat: Adding annotation option to frontend service
kuntalkumarbasu Jun 10, 2021
e312689
feat:add annotation option to gms service
kuntalkumarbasu Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions datahub-kubernetes/datahub/charts/datahub-frontend/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ metadata:
name: {{ include "datahub-frontend.fullname" . }}
labels:
{{- include "datahub-frontend.labels" . | nindent 4 }}
{{- with .Values.service.annotations }}
kuntalkumarbasu marked this conversation as resolved.
Show resolved Hide resolved
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
type: {{ .Values.service.type }}
ports:
Expand Down
4 changes: 4 additions & 0 deletions datahub-kubernetes/datahub/charts/datahub-frontend/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ securityContext: {}
service:
type: LoadBalancer
port: 9002
# Annotations to add to the service, this will help in adding
# Internal load balancer or various other annotation support in AWS
annotations: {}
# service.beta.kubernetes.io/aws-load-balancer-internal: "true"

ingress:
enabled: false
Expand Down
4 changes: 4 additions & 0 deletions datahub-kubernetes/datahub/charts/datahub-gms/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ metadata:
name: {{ printf "%s-%s" .Release.Name "datahub-gms" }}
labels:
{{- include "datahub-gms.labels" . | nindent 4 }}
{{- with .Values.service.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
type: {{ .Values.service.type }}
ports:
Expand Down
4 changes: 4 additions & 0 deletions datahub-kubernetes/datahub/charts/datahub-gms/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ securityContext: {}

service:
type: LoadBalancer #ClusterIP
# Annotations to add to the service, this will help in adding
# Internal load balancer or various other annotation support in AWS
annotations: {}
# service.beta.kubernetes.io/aws-load-balancer-internal: "true"

ingress:
enabled: false
Expand Down