fix(ingest): Use lower-case dataset names in the dataset urns for all SQL-styled datasets. #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SQL-styled datasets.
gabe-lyons
reviewed
Feb 15, 2022
Comment on lines
+38
to
+51
| SQL_STYLE_PLATFORMS: Set[str] = { | ||
| "athena", | ||
| "bigquery", | ||
| "druid", | ||
| "hive", | ||
| "mariadb", | ||
| "mssql", | ||
| "mysql", | ||
| "oracle", | ||
| "postgres", | ||
| "redshift", | ||
| "snowflake", | ||
| "trino", | ||
| } |
There was a problem hiding this comment.
is there any more generic way to specify sql systems? What's the plan for making sure this set stays updated?
There was a problem hiding this comment.
So long as we use the mce_builder to mint urns, there is no fool-proof way to ensure this, except via code-reviews. The other way would be to provide an urn minting factory that is customizable per source. That's a much bigger change, and we should do it at some point in future.
| if platform_instance: | ||
| # Use lower-case name for all SQL style datasets | ||
| if platform in SQL_STYLE_PLATFORMS: |
There was a problem hiding this comment.
There is no need to use lower-case for platform instance
rslanka
changed the title
jjoyce0510
reviewed
Feb 16, 2022
shirshanka
approved these changes
Feb 17, 2022
hevandro-veiga
pushed a commit
to hevandro-veiga/datahub
that referenced
this pull request
Feb 18, 2022
… SQL-styled datasets. (datahub-project#4140)
rslanka
added a commit
to rslanka/datahub
that referenced
this pull request
Feb 22, 2022
… for all SQL-styled datasets. (datahub-project#4140)" This reverts commit 6c75185.
4 tasks
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
… SQL-styled datasets. (datahub-project#4140)
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
… for all SQL-styled datasets. (datahub-project#4140)" (datahub-project#4218) This reverts commit 6c75185.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the dataset name to lower-case in the dataset urns for all SQL-styled datasets.
Checklist