refactor(metadata-io/test): common ElasticsearchContainer and ability to override from environment. #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test helper to introduce a common place to construct ElasticsearchContainer. To reduce duplication in tests and to allow environment variables to override the container full name. This is to allow builds behind a firewall to select the repo to use.
dexter-mh-lee
approved these changes
Feb 16, 2022
hevandro-veiga
pushed a commit
to hevandro-veiga/datahub
that referenced
this pull request
Feb 18, 2022
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(metadata-io/test): create common ElasticsearchContainer helper and ability to override from environment.
Add ElasticTestUtils to provide a common place to construct ElasticsearchContainer and create REST clients. This is to remove code duplication in tests, to ensure tests are against a consistent image of Elasticsearch. Also included is the ability to use an environment variable to override the container full name, this is to allow builds behind a firewall to specify internal source for the image.
Checklist