Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GE): add option to disable sql parsing, use default parser #4377

Merged
merged 1 commit into from
Mar 11, 2022
Merged

feat(GE): add option to disable sql parsing, use default parser #4377

merged 1 commit into from
Mar 11, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@mayurinehate mayurinehate marked this pull request as ready for review March 10, 2022 15:36
@github-actions
Copy link

Unit Test Results (build & test)

  76 files  ±0    76 suites  ±0   13m 17s ⏱️ - 3m 41s
629 tests ±0  570 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 530b3e8. ± Comparison against base commit d474387.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   47m 18s ⏱️
   360 tests    360 ✔️   0 💤 0 ❌
1 638 runs  1 607 ✔️ 31 💤 0 ❌

Results for commit 530b3e8.

mayurinehate
mayurinehate commented Mar 10, 2022
View reviewed changes
metadata-ingestion/src/datahub/utilities/sql_parser.py
from sql_metadata import Parser as MetadataSQLParser
from sqllineage.core import LineageAnalyzer

import datahub.utilities.sqllineage_patch
except ImportError:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These imports are updated to ensure that no imports needed for DefaultSQLParser (sqllineage) fail just because sql_metadata import gives an error. Earlier sequence forced to install "sql-metadata" pypi library even default parser is used.

@shirshanka shirshanka merged commit 3ea7286 into datahub-project:master Mar 11, 2022
@mayurinehate mayurinehate deleted the ge_action_option_to_disable_sql_parsing branch April 6, 2022 08:34
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@mayurinehate @maggiehays
feat(GE): add option to disable sql parsing, use default parser (data…
9e4c8f6 
…hub-project#4377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @shirshanka