-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(looker): various looker fixes #4394
fix(looker): various looker fixes #4394
Conversation
Hi @gabe-lyons, I don't think we actually need pass the per-request transport_options to each cli call as done in this PR, since every request is passed the same set of options. I think this can be done once during init31 to set these params for all subsequent calls via the client. Please let me know if I am missing something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looker is hardcoding the headers. Until that gets fixed, what you have done seems to be only way forward for us.
Co-authored-by: Shirshanka Das <[email protected]>
transport_options
to looker clientChecklist