Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(cypress): reduce cypress flakiness by retrying login on failure #4423

Merged

Conversation

gabe-lyons
Copy link
Contributor

title says it

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Unit Test Results (build & test)

  92 files  ±0    92 suites  ±0   16m 59s ⏱️ +50s
673 tests ±0  614 ✔️ ±0  59 💤 ±0  0 ±0 

Results for commit df799f5. ± Comparison against base commit 2d10d99.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabe-lyons gabe-lyons merged commit ad039aa into datahub-project:master Mar 16, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
…datahub-project#4423)

* query for custom properties on containers

* retry login in cypress

* syntax fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants