Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deletion & rollback): Server & Client side changes to support timeseries aspect deletion & rollback. #4756

Merged
merged 27 commits into from
Sep 11, 2022
Merged

feat(deletion & rollback): Server & Client side changes to support timeseries aspect deletion & rollback. #4756

merged 27 commits into from
Sep 11, 2022

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Apr 27, 2022 •
edited
Loading

This PR contains the following server-side changes to support timeseries aspect deletion and rollback:

  1. Deletion by query(filter) core implementation + unit tests
  2. Update to the delete API of EntityResource.
  3. Update to the rollback API of BatchIngestionRunResource(run).

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@rslanka
Timeseries aspect deletion, server-side changes.
36fbef4 
1. Deletion by query(filter) core implementation + unit tests
2. Update to the delete API of EntityResource.
3. Update to the rollback API of BatchIngestionRunResource(run).
@rslanka rslanka changed the title feat(deletion & rollback): Server-side changes to support for timeseries aspect deletion & rollback. feat(deletion & rollback): Server-side changes to support timeseries aspect deletion & rollback. Apr 27, 2022
@rslanka rslanka changed the title feat(deletion & rollback): Server-side changes to support timeseries aspect deletion & rollback. feat(deletion & rollback): [1/3] Server-side changes to support timeseries aspect deletion & rollback. Apr 27, 2022
@github-actions
Copy link

github-actions bot commented Apr 27, 2022 •
edited
Loading

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 30s ⏱️ - 1m 12s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ❌ ±0 

Results for commit 0e11454. ± Comparison against base commit e556bcb.

♻️ This comment has been updated with latest results.

dexter-mh-lee
dexter-mh-lee reviewed Apr 27, 2022
View reviewed changes
metadata-io/src/main/java/com/linkedin/metadata/timeseries/TimeseriesAspectService.java Outdated Show resolved Hide resolved
...main/java/com/linkedin/metadata/timeseries/elastic/ElasticSearchTimeseriesAspectService.java Outdated Show resolved Hide resolved
...let-impl/src/main/java/com/linkedin/metadata/resources/entity/BatchIngestionRunResource.java Outdated Show resolved Hide resolved
...let-impl/src/main/java/com/linkedin/metadata/resources/entity/BatchIngestionRunResource.java Outdated Show resolved Hide resolved
...restli-servlet-impl/src/main/java/com/linkedin/metadata/resources/entity/EntityResource.java Outdated Show resolved Hide resolved
...restli-servlet-impl/src/main/java/com/linkedin/metadata/resources/entity/EntityResource.java Show resolved Hide resolved
...restli-servlet-impl/src/main/java/com/linkedin/metadata/resources/entity/EntityResource.java Outdated Show resolved Hide resolved
...restli-servlet-impl/src/main/java/com/linkedin/metadata/resources/entity/EntityResource.java Outdated Show resolved Hide resolved
...restli-servlet-impl/src/main/java/com/linkedin/metadata/resources/entity/EntityResource.java Outdated Show resolved Hide resolved
...restli-servlet-impl/src/main/java/com/linkedin/metadata/resources/entity/EntityResource.java Outdated Show resolved Hide resolved
@rslanka rslanka changed the title feat(deletion & rollback): [1/3] Server-side changes to support timeseries aspect deletion & rollback. feat(deletion & rollback): Server & Client side changes to support timeseries aspect deletion & rollback. May 23, 2022
@github-actions
Copy link

github-actions bot commented May 23, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   55m 44s ⏱️ -5s
   692 tests ±0     689 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 384 runs  ±0  1 378 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 0e11454. ± Comparison against base commit e556bcb.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Jul 26, 2022
shirshanka
shirshanka approved these changes Sep 11, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 386719f into datahub-project:master Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter-mh-lee dexter-mh-lee dexter-mh-lee left review comments

@shirshanka shirshanka shirshanka approved these changes

Assignees

@dexter-mh-lee dexter-mh-lee

Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rslanka @dexter-mh-lee @shirshanka @anshbansal