Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metabase): Missing charts from dashboard #4942

Merged
merged 2 commits into from
May 25, 2022
Merged

fix(metabase): Missing charts from dashboard #4942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e0dd8a
metabase chart are missing from dashboard
siddiquebagwan-gslab May 18, 2022
a765041
Merge branch 'master' into master+metabase-fix-dashboard-chart-count
siddiquebagwan-gslab May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/metabase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,8 +595,8 @@ def create(cls, config_dict: dict, ctx: PipelineContext) -> Source:
return cls(ctx, config)

def get_workunits(self) -> Iterable[MetadataWorkUnit]:
yield from self.emit_dashboard_mces()
yield from self.emit_card_mces()
yield from self.emit_dashboard_mces()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm somewhat confused - Can you explain how this change fixes missing charts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have dashboards emitted before charts then dashboards will have charts in the chart tabs. But when we go to the chart itself it will be missing by clicking on the chart. This is noticeable only when dashboard ingestion is taking too long or it fails.


def get_report(self) -> SourceReport:
return self.report